Nagato-Yuzuru commented on code in PR #26086:
URL: https://github.com/apache/datafusion/pull/26086#discussion_r4375817826
##########
datafusion/core/tests/fuzz_cases/equivalence/utils.rs:
##########
@@ -503,16 +561,25 @@ pub fn generate_table_for_orderings(
Ok(batch)
}
+pub const NULL_PCTS: &[f64] = &[0.0, 0.1, 0.5];
Review Comment:
Added both cases in f49799e15. Without the Singleton guard in
SortProperties::and/or, the NULL constant test fails. An all-NULL column cannot
break an ordering, so that test fails only when an expected ordering is not
inferred.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
