github-actions[bot] commented on PR #26769: URL: https://github.com/apache/datafusion/pull/26769#issuecomment-6418795820
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning 350ca76505c9513d16e7dd9910bcd9bde2c911ed Building datafusion v55.1.0 (current) Built [ 63.438s] (current) Parsing datafusion v55.1.0 (current) Parsed [ 0.036s] (current) Building datafusion v55.1.0 (baseline) Built [ 17.752s] (baseline) Parsing datafusion v55.1.0 (baseline) Parsed [ 0.038s] (baseline) Checking datafusion v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.635s] 229 checks: 229 pass, 31 skip Summary no semver update required Finished [ 83.451s] datafusion Building datafusion-expr v55.1.0 (current) Built [ 22.923s] (current) Parsing datafusion-expr v55.1.0 (current) Parsed [ 0.108s] (current) Building datafusion-expr v55.1.0 (baseline) Built [ 7.552s] (baseline) Parsing datafusion-expr v55.1.0 (baseline) Parsed [ 0.111s] (baseline) Checking datafusion-expr v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 1.409s] 229 checks: 227 pass, 2 fail, 0 warn, 31 skip --- failure constructible_struct_adds_field: struct exhaustively constructible through public API adds field --- Description: A pub struct that could be exhaustively constructed with a literal using only public API has a new pub field, breaking existing exhaustive literals. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/constructible_struct_adds_field.ron Failed in: field Alias.origin in /home/runner/work/datafusion/datafusion/datafusion/expr/src/expr.rs:740 --- failure enum_struct_variant_field_added: pub enum struct variant field added --- Description: An enum's exhaustive struct variant has a new field, which has to be included when constructing or matching on this variant. ref: https://doc.rust-lang.org/reference/attributes/type_system.html#the-non_exhaustive-attribute impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/enum_struct_variant_field_added.ron Failed in: field origin of variant SavedName::Saved in /home/runner/work/datafusion/datafusion/datafusion/expr/src/expr_rewriter/mod.rs:352 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 32.917s] datafusion-expr Building datafusion-optimizer v55.1.0 (current) Built [ 17.431s] (current) Parsing datafusion-optimizer v55.1.0 (current) Parsed [ 0.036s] (current) Building datafusion-optimizer v55.1.0 (baseline) Built [ 7.712s] (baseline) Parsing datafusion-optimizer v55.1.0 (baseline) Parsed [ 0.038s] (baseline) Checking datafusion-optimizer v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.166s] 229 checks: 229 pass, 31 skip Summary no semver update required Finished [ 26.068s] datafusion-optimizer Building datafusion-physical-expr v55.1.0 (current) Built [ 3.750s] (current) Parsing datafusion-physical-expr v55.1.0 (current) Parsed [ 0.059s] (current) Building datafusion-physical-expr v55.1.0 (baseline) Built [ 3.741s] (baseline) Parsing datafusion-physical-expr v55.1.0 (baseline) Parsed [ 0.062s] (baseline) Checking datafusion-physical-expr v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.377s] 229 checks: 229 pass, 31 skip Summary no semver update required Finished [ 8.712s] datafusion-physical-expr Building datafusion-proto v55.1.0 (current) Built [ 29.222s] (current) Parsing datafusion-proto v55.1.0 (current) Parsed [ 0.013s] (current) Building datafusion-proto v55.1.0 (baseline) Built [ 22.030s] (baseline) Parsing datafusion-proto v55.1.0 (baseline) Parsed [ 0.014s] (baseline) Checking datafusion-proto v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.144s] 229 checks: 229 pass, 31 skip Summary no semver update required Finished [ 52.603s] datafusion-proto Building datafusion-proto-models v55.1.0 (current) Built [ 18.318s] (current) Parsing datafusion-proto-models v55.1.0 (current) Parsed [ 0.172s] (current) Building datafusion-proto-models v55.1.0 (baseline) Built [ 6.257s] (baseline) Parsing datafusion-proto-models v55.1.0 (baseline) Parsed [ 0.175s] (baseline) Checking datafusion-proto-models v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 1.973s] 229 checks: 228 pass, 1 fail, 0 warn, 31 skip --- failure constructible_struct_adds_field: struct exhaustively constructible through public API adds field --- Description: A pub struct that could be exhaustively constructed with a literal using only public API has a new pub field, breaking existing exhaustive literals. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/constructible_struct_adds_field.ron Failed in: field AliasNode.origin in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1048 field AliasNode.origin in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1048 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 28.235s] datafusion-proto-models Building datafusion-sql v55.1.0 (current) Built [ 20.487s] (current) Parsing datafusion-sql v55.1.0 (current) Parsed [ 0.034s] (current) Building datafusion-sql v55.1.0 (baseline) Built [ 12.874s] (baseline) Parsing datafusion-sql v55.1.0 (baseline) Parsed [ 0.036s] (baseline) Checking datafusion-sql v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.275s] 229 checks: 229 pass, 31 skip Summary no semver update required Finished [ 34.597s] datafusion-sql ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
