ninglinLiu commented on code in PR #7218:
URL: https://github.com/apache/datafusion-comet/pull/7218#discussion_r4379536617
##########
spark/src/test/scala/org/apache/comet/SparkErrorConverterSuite.scala:
##########
@@ -59,6 +59,19 @@ class SparkErrorConverterSuite extends AnyFunSuite {
}
}
+ test("NumericOutOfRange converts to a SparkArithmeticException like Spark") {
Review Comment:
Agreed, the fixture covers the exception class, error class and SQLSTATE
through the real native path. Dropped the converter test in db0975b, so the PR
is now the three shim changes plus `cast_string_to_decimal_ansi.sql`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
