comphead commented on code in PR #7218:
URL: https://github.com/apache/datafusion-comet/pull/7218#discussion_r4379460654
##########
spark/src/test/scala/org/apache/comet/SparkErrorConverterSuite.scala:
##########
@@ -59,6 +59,19 @@ class SparkErrorConverterSuite extends AnyFunSuite {
}
}
+ test("NumericOutOfRange converts to a SparkArithmeticException like Spark") {
Review Comment:
With `cast_string_to_decimal_ansi.sql` in place, this test repeats what the
fixture checks. `expect_error_class` goes through `checkSparkError`, which
compares the exception class, the error class and the SQLSTATE with Spark's,
and you confirmed it fails without the shim change. What this test adds is the
`value` parameter, read back from JSON written by hand, so it does not show the
native side sends that value. Could this test be dropped in favor of the
fixture?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
