cool9850311 commented on PR #26773: URL: https://github.com/apache/datafusion/pull/26773#issuecomment-6432176384
Sorry about the branch churn here. I first pushed these changes as a rewrite of the two commits you reviewed, which was the wrong call — it pulled the base out from under your comments. `6e4279ca3` is back exactly as you reviewed it and the changes sit on top of it, so the diff since your review is intact: - `0d1977d` `test: cover the limit a window the rule can't grow past used to strand` — the coverage from your first comment - `ac5c565` `refactor: take the traversal state in apply_limit` — your second comment Two things my replies above said while the rewrite was live and which no longer hold: the commits keep their original titles, since relabelling `dd82ddcf` to `fix:` would mean rewriting it again — the PR description carries that point instead — and the two new cases are in their own commit rather than folded into the first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
