sunchao commented on PR #7190: URL: https://github.com/apache/datafusion-comet/pull/7190#issuecomment-6447165440
@viirya Addressed this round in 5ba986ac5c. The admission guard now explains the fair-pool/Spark spill interaction and its best-effort scope. Rejected admission logs the sort ID and reason. A committed Spark test exercises both admission outcomes through JNI with a same-task memory consumer. The coalescer drains all completed batches, and the 128-row target has a rationale comment. Local validation passed 50 native operator tests, 42 native join tests, all three focused Spark 3.5.9 reduction tests with the rebuilt native library, strict Spark/Delta compilation, formatting, syntactic lint and operator Clippy. The resident-memory test emitted the new debug message. The PR description records the temporary dependency-lock limitation and distinguishes the earlier benchmark measurements from this follow-up, which has not been rebenchmarked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
