comphead commented on code in PR #7195:
URL: https://github.com/apache/datafusion-comet/pull/7195#discussion_r4391176097
##########
spark/src/test/scala/org/apache/comet/CometNativeCastSuite.scala:
##########
@@ -128,6 +128,81 @@ class CometNativeCastSuite
}
}
+ test("non-collect LIMIT skips a failing cast beyond its projection input
cap") {
Review Comment:
The behavior checks in this test are a `query` that must match Spark, an
error for `limit + 1`, an AQE on and off matrix and a few
`spark.comet.batchSize` values, which `CometSqlFileTestSuite` supports.
`array_append_eager_eval.sql` is a precedent with the same shape (`-- Config:
spark.sql.ansi.enabled=true`, `/*+ COALESCE(1) */` for a single file and an
`expect_error_class`), and `array_null_short_circuit.sql` already uses
`expect_error(CAST_INVALID_INPUT)`. The plan-shape assertion on
`CometLocalLimitExec.limit == limit + offset` is covered by the
`CometExecRuleSuite` loops over collect, local and global limits, so this test
could shrink to the parts a fixture cannot express. The `#6035` sibling test
lives in this suite in Scala, so keeping the pattern is defensible. The
dispatch assertion needs a `-- Config:` line for the codegen setting. I have
not run such a fixture.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
