alamb commented on code in PR #25807:
URL: https://github.com/apache/datafusion/pull/25807#discussion_r4393885938
##########
datafusion-cli/src/exec.rs:
##########
@@ -126,13 +126,24 @@ pub async fn exec_from_repl(
print_options: &mut PrintOptions,
) -> rustyline::Result<()> {
let mut rl = Editor::new()?;
- rl.set_helper(Some(CliHelper::new(
- &ctx.task_ctx().session_config().options().sql_parser.dialect,
- print_options.color,
- )));
+ {
+ let task_ctx = ctx.task_ctx();
Review Comment:
is there some way to avoid copy/pasting the same code 3 times in this code?
Perhaps making a helper function or somethig?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
