namanjain24-sudo commented on PR #25527: URL: https://github.com/apache/datafusion/pull/25527#issuecomment-6452314698
Apologies for the stray comment — a benchmark report meant for a different repository that I posted here by mistake. Removing it; please ignore the notification. On the PR itself: closing it as I said I would. @alexandrefimov, thank you for the two rounds of review — the unregistered `equal` anchor and the old-plan regression were both real, and the switch to `SwitchExpression` came directly out of that. @alamb, the size objection was fair; this ended up bigger than the bug warrants. The underlying mismatch is still there (Substrait's trailing column is a grouping-set index, DataFusion's `__grouping_id` is a bitmask), so I've left the analysis and the tests on the branch for anyone who wants them. Happy to reopen, or to split it consumer-first, if a Substrait maintainer ever wants to pick it up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
