sunchao commented on code in PR #7235: URL: https://github.com/apache/datafusion-comet/pull/7235#discussion_r4395220975
########## spark/src/test/scala/org/apache/spark/sql/comet/execution/arrow/ArrowCachedBatchStatsSuite.scala: ########## @@ -0,0 +1,159 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.spark.sql.comet.execution.arrow + +import java.math.{BigDecimal => JBigDecimal, BigInteger} + +import scala.util.Random + +import org.scalatest.funsuite.AnyFunSuite + +import org.apache.arrow.c.CDataDictionaryProvider +import org.apache.arrow.vector.DecimalVector +import org.apache.spark.sql.catalyst.expressions.AttributeReference +import org.apache.spark.sql.types.{Decimal, DecimalType} +import org.apache.spark.sql.vectorized.{ColumnarBatch, ColumnVector} + +import org.apache.comet.CometArrowAllocator +import org.apache.comet.vector.CometVector + +/** The bounds and null counts `ArrowCachedBatchSerializer` records for decimal columns. */ +class ArrowCachedBatchStatsSuite extends AnyFunSuite { Review Comment: Could you register `org.apache.spark.sql.comet.execution.arrow.ArrowCachedBatchStatsSuite` in the suite lists in both `.github/workflows/pr_build_linux.yml` and `pr_build_macos.yml`? Neither currently includes this new suite. I reproduced `dev/ci/check-suites.py` exiting with code 255, and the [current-head Preflight job](https://github.com/apache/datafusion-comet/actions/runs/40324772416/job/121578544980) fails with the same missing-suite message. This stops the normal build/test jobs before these decimal-boundary tests can run. Adding the suite to both lists is needed to restore CI and keep this regression coverage active. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
