andygrove commented on code in PR #7221:
URL: https://github.com/apache/datafusion-comet/pull/7221#discussion_r4395809087
##########
native/core/src/parquet/objectstore/azure.rs:
##########
@@ -129,6 +136,21 @@ pub fn create_store(
Ok((Box::new(store), path))
}
+/// Why [`create_store`] cannot build a store for `url` from `configs`, or
`None` when it can.
+/// The driver asks this at planning time so that a scan the store would
reject falls back to
+/// Spark, from the same code the scan runs instead of a copy of its rules.
Building makes no
+/// request, and the message names keys, never their values.
+pub fn store_error(url: &str, configs: &HashMap<String, String>) ->
Option<String> {
+ let url = match Url::parse(url) {
+ Ok(url) => url,
+ Err(e) => return Some(format!("invalid ABFS URL: {e}")),
Review Comment:
url could contain sensitive info?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
