xavlee commented on code in PR #24698:
URL: https://github.com/apache/datafusion/pull/24698#discussion_r4402297546
##########
datafusion/physical-expr/src/equivalence/properties/mod.rs:
##########
@@ -348,6 +366,13 @@ impl EquivalenceProperties {
self.oeq_cache.clear();
}
+ /// Clears grouping information invalidated by an operation that changes
Review Comment:
Thanks @jayzhan211. Assuming we have no existing operators that would change
ordering but somehow maintain groupings, the conservative route to clear
groupings in clear orderings makes sense to me.
I added this as a follow-up PR here:
https://github.com/apache/datafusion/pull/26852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
