alamb commented on code in PR #26270:
URL: https://github.com/apache/datafusion/pull/26270#discussion_r4405812738
##########
datafusion/execution/src/task.rs:
##########
@@ -53,6 +69,71 @@ pub struct TaskContext {
window_functions: HashMap<String, Arc<WindowUDF>>,
/// Runtime environment associated with this task context
runtime: Arc<RuntimeEnv>,
+ /// State that operators keep for one run of a plan
+ run_state: Arc<RunState>,
+}
+
+/// State that the operators of a plan keep for one run of that plan.
Review Comment:
I think @askalt had a similar idea about separating out the per-plan state
of the operators into a separate structure
##########
datafusion/execution/src/task.rs:
##########
@@ -35,7 +51,7 @@ use std::{collections::HashMap, sync::Arc};
///
/// [`SessionContext`]:
https://docs.rs/datafusion/latest/datafusion/execution/context/struct.SessionContext.html
/// [`ExecutionProps`]: datafusion_expr::execution_props::ExecutionProps
-#[derive(Debug)]
+#[derive(Debug, Clone)]
Review Comment:
why does it need to be clone?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
