andygrove commented on code in PR #7299: URL: https://github.com/apache/datafusion-comet/pull/7299#discussion_r4414427351
########## native/native-executors/Cargo.toml: ########## @@ -0,0 +1,61 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Comet Native Executors: the comet-scheduler and comet-executor binaries, built on Apache +# DataFusion Ballista. See https://github.com/apache/datafusion-comet/issues/7288. +# +# This is its own workspace, with its own lockfile, so that the main Comet build never depends +# on Ballista. It builds Comet's native crates by path together with the Ballista release on the +# same DataFusion major version. +[workspace] Review Comment: Added in 53ea7d4f39: a `cargo` entry for `/native/native-executors` with the same ignore and grouping rules as `/native`. The lock resolves arrow to 59.3.2 while `native/Cargo.lock` has 59.3.1, so the job currently tests the core crate against a newer arrow than `libcomet` ships with. I left that alone because the next Dependabot run on `/native` should close the gap, and the README now says the two lockfiles can differ between updates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
