github-actions[bot] commented on PR #26835: URL: https://github.com/apache/datafusion/pull/26835#issuecomment-6500441189
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning 22eb8ff1023881f6e11f53b65b806d0585f51e39 Building datafusion-expr v55.1.0 (current) Built [ 28.268s] (current) Parsing datafusion-expr v55.1.0 (current) Parsed [ 0.094s] (current) Building datafusion-expr v55.1.0 (baseline) Built [ 6.671s] (baseline) Parsing datafusion-expr v55.1.0 (baseline) Parsed [ 0.096s] (baseline) Checking datafusion-expr v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 2.001s] 229 checks: 227 pass, 2 fail, 0 warn, 31 skip --- failure method_parameter_count_changed: pub method parameter count changed --- Description: A publicly-visible method now takes a different number of parameters, not counting the receiver (self) parameter. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/method_parameter_count_changed.ron Failed in: datafusion_expr::ScalarUDF::supports_range_key_locality_analysis takes 1 parameters in /home/runner/work/datafusion/datafusion/target/semver-checks-shared/semver-checks/git-22eb8ff1023881f6e11f53b65b806d0585f51e39/fee3941f795683524f7f64e38c043b147b36b557/datafusion/expr/src/udf.rs:355, but now takes 2 parameters in /home/runner/work/datafusion/datafusion/datafusion/expr/src/udf.rs:355 --- failure trait_method_parameter_count_changed: pub trait method parameter count changed --- Description: A trait method now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/trait_method_parameter_count_changed.ron Failed in: ScalarUDFImpl::supports_range_key_locality_analysis now takes 2 instead of 1 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/expr/src/udf.rs:1006 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 39.056s] datafusion-expr Building datafusion-functions v55.1.0 (current) Built [ 22.234s] (current) Parsing datafusion-functions v55.1.0 (current) Parsed [ 0.095s] (current) Building datafusion-functions v55.1.0 (baseline) Built [ 6.292s] (baseline) Parsing datafusion-functions v55.1.0 (baseline) Parsed [ 0.095s] (baseline) Checking datafusion-functions v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.493s] 229 checks: 229 pass, 31 skip Summary no semver update required Finished [ 30.684s] datafusion-functions Building datafusion-physical-expr v55.1.0 (current) Built [ 3.189s] (current) Parsing datafusion-physical-expr v55.1.0 (current) Parsed [ 0.050s] (current) Building datafusion-physical-expr v55.1.0 (baseline) Built [ 3.318s] (baseline) Parsing datafusion-physical-expr v55.1.0 (baseline) Parsed [ 0.051s] (baseline) Checking datafusion-physical-expr v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.420s] 229 checks: 229 pass, 31 skip Summary no semver update required Finished [ 7.964s] datafusion-physical-expr ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
