xavlee commented on PR #24698: URL: https://github.com/apache/datafusion/pull/24698#issuecomment-6501711668
Hi @jayzhan211, I came across another finding- we may also want to propagate grouping properties through UnionExec. Currently, [we construct a new EquivalenceProperties and only add back constants and orderings](https://github.com/apache/datafusion/blob/main/datafusion/physical-expr/src/equivalence/properties/union.rs#L64-L67). However, since UnionExec maintains isolated partitions, grouping properties should also be maintained. On the other hand, InterleaveExec should not propagate groupings since it combines partitions, potentially breaking contiguity. Please let me know if this makes sense, and if I should add this as part of this PR or in another followup 🙇 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
