Abhishek-Mohan opened a new pull request, #7331:
URL: https://github.com/apache/datafusion-comet/pull/7331

   ## Which issue does this PR close?
   
   Closes #7101.
   
   ## Rationale for this change
   
   Four Scala comments still name the user-guide `iceberg-writes.md` page 
removed by #7090. Two give a nonexistent path; two give a bare filename that 
can be confused with the contributor-guide page.
   
   ## What changes are included in this PR?
   
   Point all four comments to `docs/source/user-guide/latest/iceberg.md` and 
name "Accepted divergences" under Writes. The references cover compression, 
fanout ordering, and file rolling in the two Iceberg benchmarks.
   
   The patch changes comments only. #5724 and its follow-up #7226 also update 
the write-benchmark reference on their open branches; all four references 
remain stale on main at submission.
   
   ## How are these changes tested?
   
   - Verified that the target page, Writes and Accepted divergences headings, 
and the compression, fanout-ordering, and file-rolling entries exist.
   - Confirmed no stale `iceberg-writes.md` references remain in Scala sources.
   - Compared non-comment source lines against the base: unchanged in all four 
files.
   - `git diff --check` passed.
   - Offline Spotless check passed for all four changed files:
   
   ```shell
   ./mvnw -o spotless:check 
"-DspotlessFiles=.*(IcebergWriteProtoTranslation|CometIcebergWriteActionSuite|CometIcebergEndToEndBenchmark|CometIcebergWriteBenchmark)\.scala"
   ```
   
   No new tests or runtime test runs: only documentation comments changed. No 
local compilation, Maven install, or local-ci preparation was run. The 
contributor guidance also calls for CI coverage on the affected paths; a 
maintainer can enable `run-spark-4.1-tests`, `run-iceberg-tests`, and 
`run-benchmark-check` because the submitting account cannot manage upstream 
labels.
   
   ## Council review
   
   Reviewed using the t3dotgg/tstack council workflow. All delegates were 
satisfied with no required changes.
   
   Rounds: 1
   
   | Delegate | Round 1 |
   | --- | --- |
   | Claude Opus 5.5 | 9.5/10 |
   | Gemini 4 Argon | 10/10 |
   | GPT-6 Astra | 10/10 |
   
   Created with GPT-6 Astra in OpenCode through T3 Code. Claude Opus 5.5 
performed the implementation handoff pass and confirmed no further edits were 
needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to