geoffreyclaude commented on code in PR #26603:
URL: https://github.com/apache/datafusion/pull/26603#discussion_r4412854460
##########
datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:
##########
@@ -215,6 +215,24 @@ pub trait SubstraitConsumer: Send + Sync + Sized {
from_substrait_rel(self, rel).await
}
+ /// Consumes independent inputs of a JOIN or UNION, returning plans in
input order.
Review Comment:
For this to be complete, I think makes sense to extend it to other types of
multi-children relations. `CrossRel` for instance, but probably not only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
