EthanVieira commented on PR #2594:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2594#issuecomment-6522872434
> I believe that we need to make the `Table` struct hold an `ObjectName`, as
`TableFactor::Table` does, so a qualified name of any length keeps its parts.
>
> ```diff
> @@ -300,6 +300,4 @@ impl fmt::Display for SetQuantifier {
> pub struct Table {
> - /// Optional table name (absent for e.g. `TABLE` command without
argument).
> - pub table_name: Option<Ident>,
> - /// Optional schema/catalog name qualifying the table.
> - pub schema_name: Option<Ident>,
> + /// Optional, possibly qualified, table name (absent for e.g. `TABLE`
command without argument).
> + pub name: Option<ObjectName>,
> }
> ```
>
> This of course will call for several changes both in the repo and
downstream, but it seems like the cleanest solution to me. @alamb opinions?
Haven't heard from @alamb, but I went ahead and did this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
