devanbenz commented on code in PR #26249:
URL: https://github.com/apache/datafusion/pull/26249#discussion_r4424811073
##########
datafusion/physical-plan/src/joins/key_range_bitmap.rs:
##########
@@ -101,6 +114,67 @@ impl KeyRangeBitmap {
})
}
+ /// One bitmap over `[min, max]` marking every bucket that any of `parts`
+ /// may hold a key in. `[min, max]` must cover every part.
+ ///
+ /// Coarser than the parts' own bitmaps where its buckets are wider, but
+ /// never clears a bucket a part may hold a key in. `None` when the key
+ /// type has no `u64` ordering, or when nothing can be excluded.
+ pub(crate) fn union(
Review Comment:
Sounds good, adding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
