yunchipang commented on code in PR #7100:
URL: https://github.com/apache/datafusion-comet/pull/7100#discussion_r4429540587
##########
spark/src/main/scala/org/apache/comet/serde/operator/CometIcebergNativeWrite.scala:
##########
@@ -553,6 +563,24 @@ object CometIcebergNativeWrite extends
CometOperatorSerde[IcebergWriteExec] {
}
}
+ // Top-level `unknown` columns are pruned from the native schema, so a
partition field sourced
+ // from one would fail the native partition calculator with `Field not
found`.
+ private val requireNoUnknownPartitionSource: TriggerRule = ctx =>
Review Comment:
good idea! done: `requireOutputPartitionSpec(check)` resolves the spec and
catches reflection errors; each rule passes only its check. If #7198 lands
first, I'll widen `check` to take `ctx`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
