yunchipang commented on code in PR #7100: URL: https://github.com/apache/datafusion-comet/pull/7100#discussion_r4429642987
########## docs/source/contributor-guide/iceberg-writes.md: ########## @@ -276,7 +276,9 @@ Points where Comet adapts iceberg-rust to match iceberg-java: held rows then go through `RowPacer`, so the roll grid does not move. - **Field ids and casting.** `decorate_batch_with_field_ids` casts each batch to the field-id-annotated Arrow schema derived from the Iceberg schema, with `safe: false`, so a type - mismatch fails the task instead of writing NULLs. + mismatch fails the task instead of writing NULLs. It first drops top-level `unknown` columns, + whose fields `parse_iceberg_schema` prunes, so the gate declines a partition field sourced from + one. Review Comment: updated. please lmk if it's making more sense now. thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
