jayzhan211 commented on code in PR #26461:
URL: https://github.com/apache/datafusion/pull/26461#discussion_r4429781871
##########
datafusion/core/tests/memory_limit/mod.rs:
##########
@@ -578,7 +578,7 @@ async fn sort_merge_join_no_spill() {
])
.with_memory_limit(1_000)
.with_config(config)
- .with_scenario(Scenario::AccessLogStreaming)
+ .with_scenario(Scenario::AccessLogStreamingByPodTime)
Review Comment:
These two tests aren't checking optimizer errors. They still check the sort
merge join's memory use. Their rule list is only `JoinSelection`, so the
`SortMergeJoinExec` read unsorted input, and it ran only because that list left
out `SanityCheckPlan`. The planner now rejects that plan, so the tests sort the
generated rows by the join keys and declare that order on the table. That keeps
the plan valid without adding a `SortExec`, whose memory budget would be hit
before the join's. The optimizer error tests are in
`core/tests/physical_optimizer/sanity_checker.rs`, so I'd keep these two here
as they are.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
