andygrove commented on code in PR #2730:
URL:
https://github.com/apache/datafusion-ballista/pull/2730#discussion_r4485647002
##########
ballista/scheduler/src/scheduler_server/event.rs:
##########
@@ -141,6 +142,25 @@ pub enum QueryStageSchedulerEvent {
/// Timestamp when the job failed.
failed_at: u64,
},
+ /// A job lost `DataFrame::cache()` data it reads; the stages reading it
wait
+ /// until it is provided again.
+ ExternalInputLost {
Review Comment:
Small one on `QueryStageSchedulerEvent`. The two new variants will break
anyone downstream doing an exhaustive match on it, since the enum is public and
shipped in 55. Would you mind either adding `#[non_exhaustive]` to the enum
while you're here, or adding a short note to the 56.0.0 upgrade guide? I'd lean
toward `#[non_exhaustive]` so we stop paying this cost on every new event.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
