juliomax commented on issue #2597:
URL:
https://github.com/apache/datafusion-ballista/issues/2597#issuecomment-6723158431
Thanks for writing this up. I'd like to take it. The #2593 prerequisite is
merged (#2607).
Plan: a behaviour-preserving refactor, with tests that pin the current
behaviour added
before each extraction.
1. Extract `resolve_vcores`, `spawn_shuffle_cleaner`, `run_until_shutdown`
and
`build_memory_pool_policy`. These shouldn't overlap textually with the
open PRs touching
`executor_process.rs` (#2715, #2775, #2797, #2794), though #2797/#2794
touch nearby
memory-pool code, so I'll do that one last and move it to step 2 if they
land first.
2. `build_endpoint` + `connect_to_scheduler` once #2715 lands.
3. `resolve_work_dir` once #2775 lands.
Two questions before I start:
- Is splitting it into three PRs like this fine, or would you rather have a
single PR once
the open ones are in?
- For the unified connect path I'd keep today's errors as they are
(`GrpcConnectionError`
messages with timeout 0, "Timed out attempting to connect" otherwise), so
the refactor
changes no observable behaviour. Does that work for you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
