ted-jenks opened a new pull request, #7528: URL: https://github.com/apache/datafusion-comet/pull/7528
## Which issue does this PR close? Closes #7022. ## Rationale for this change Since #5050 the serde never sends a negative scale into these kernels, but nothing in them rejects one. A new path would panic in debug builds or return zeros or divide by zero in release builds. One existing native route is the Parquet schema adapter, which accepts integer columns read as a negative-scale decimal. ## What changes are included in this PR? A `decimal_scale_factor` helper built on `pow10_i128` now guards the four kernels. ## How are these changes tested? `test_cast_kernels_reject_negative_scale` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
