xudong963 commented on PR #27021: URL: https://github.com/apache/datafusion/pull/27021#issuecomment-6731201633
I found one correctness issue that needs fixing before merge: `find_header_line` treats the first raw terminator byte as the header boundary without respecting CSV quote/escape state. I reproduced it with `;` as the terminator and `"a;b",c;` as the header; the scan fails with an incorrect field-count error even though the file is valid CSV. How about making header discovery use the same quote-aware parsing semantics as Arrow/csv-core and adding that case as an end-to-end regression. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
