rich7420 commented on code in PR #7456:
URL: https://github.com/apache/datafusion-comet/pull/7456#discussion_r4511391206
##########
spark/src/main/scala/org/apache/comet/serde/arithmetic.scala:
##########
@@ -208,7 +219,8 @@ object CometAdd extends CometExpressionSerde[Add] with
MathBase {
binding,
expr.dataType,
expr.evalMode,
- (builder, mathExpr) => builder.setAdd(mathExpr))
+ (builder, mathExpr) => builder.setAdd(mathExpr),
+ skippable = Some(expr.right))
Review Comment:
Every LEGACY integer `+`/`*`, even with two operands, takes the balanced
branch without the flag, so `n + element_at(a, 0)` fails where `n` is NULL.
Could each balanced node set it from its right slice, matching Spark's
left-deep chain?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
