xudong963 commented on PR #27251: URL: https://github.com/apache/datafusion/pull/27251#issuecomment-6737029132
Thanks @matthewmturner, I found one correctness blocker: `struct_field_names_match` zips union children by storage order even though Arrow and DataFusion match them by type ID, which can both reject valid reordered unions and accept mismatched nested struct names. How about matching union children by type ID and adding focused unit coverage? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
