Phoenix500526 commented on code in PR #27256:
URL: https://github.com/apache/datafusion/pull/27256#discussion_r4514320098


##########
datafusion/physical-optimizer/src/join_selection.rs:
##########
@@ -383,6 +388,12 @@ fn hash_join_convert_symmetric_subrule(
             hash_join.right.pipeline_behavior(),
             EmissionType::Incremental | EmissionType::Both
         );
+        if left_unbounded && right_unbounded && hash_join.null_aware {
+            return plan_err!(
+                "Cannot execute a null-aware join with two unbounded inputs: \
+                 SymmetricHashJoinExec does not support null-aware semantics."
+            );
+        }
         // Process only if both left and right sides are unbounded and 
incrementally emit.
         if left_unbounded && right_unbounded & left_incremental & 
right_incremental {

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to