rich7420 commented on code in PR #7450:
URL: https://github.com/apache/datafusion-comet/pull/7450#discussion_r4511335598
##########
spark/src/main/scala/org/apache/comet/serde/strings.scala:
##########
@@ -561,7 +561,7 @@ object CometRLike
}
private object PadReasons {
- val literalStrReason = "Scalar values are not supported for the `str`
argument."
+ val literalStrReason = "Literal values are not supported for the `str`
argument."
Review Comment:
Separately, `lpad`/`rpad` don't go through `withNullShortCircuit`, so in
ANSI mode `lpad(s, CAST(t AS INT))` evaluates the cast on rows where `s` is
NULL, which Spark skips. Worth a follow-up issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
