xavlee commented on code in PR #27238:
URL: https://github.com/apache/datafusion/pull/27238#discussion_r4516445451
##########
datafusion/physical-expr/src/equivalence/class.rs:
##########
@@ -157,13 +153,17 @@ impl From<Arc<dyn PhysicalExpr>> for ConstExpr {
}
}
-/// An `EquivalenceClass` is a set of [`Arc<dyn PhysicalExpr>`]s that are known
-/// to have the same value for all tuples in a relation. These are generated by
-/// equality predicates (e.g. `a = b`), typically equi-join conditions and
-/// equality conditions in filters.
+/// A set of [`Arc<dyn PhysicalExpr>`]s that are known
+/// to have the same value for all tuples in a relation.
+///
+/// `EquivalenceClass`es are generated by equality predicates such as `a = b`,
+/// typically equi-join conditions and conditions in filters. See
+/// [Equivalent expressions] for more detail.
///
-/// Two `EquivalenceClass`es are equal if they contains the same expressions in
+/// Two `EquivalenceClass`es are equal if they contain the same expressions in
/// without any ordering.
Review Comment:
I'm reading this in that given expressions `a` and `b`, `[a, b] == [b, a]`.
If so, we could probably fix this typo
```suggestion
/// Two `EquivalenceClass`es are equal if they contain the same expressions,
regardless
/// of their order.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
