vinycalves opened a new pull request, #27275: URL: https://github.com/apache/datafusion/pull/27275
Closes #17498. This is the column-specific follow-up to #25784: the global parquet encoding is validated when it is set, but ParquetColumnOptions.encoding still stores a string, so an invalid format.encoding::column is only rejected when a write starts. This changes the field to the existing DFParquetEncoding, updates both proto conversion paths, and adds tests for valid and invalid values. The relevant tests in datafusion-common, datafusion-proto-common and datafusion-proto-models pass, and clippy is clean. Because ParquetColumnOptions.encoding changes from Option<String> to Option<DFParquetEncoding>, this needs the api change label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
