andygrove commented on issue #2893: URL: https://github.com/apache/datafusion-sqlparser-rs/issues/2893#issuecomment-6754466847
The biggest blocker for integrating into DataFusion currently (which is one of the gates that @alamb proposed, and that I agree with) is that `DFParser` holds a `&dyn Dialect`, but v2's `Parser` is generic over a static dialect. Not sure if that totally kills the proposed approach. I'll take a fresh look at that tomorrow. We definitely need to be able to choose dialects at runtime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
