vinycalves commented on code in PR #27273: URL: https://github.com/apache/datafusion/pull/27273#discussion_r4525533757
########## datafusion/common/src/config.rs: ########## Review Comment: If 'legacy_java_charsets' does not accept every Java charset, is the name honest? ########## datafusion/sqllogictest/test_files/spark/string/encode.slt: ########## Review Comment: What does encode of a NULL value with an invalid charset return, and is that Spark's behavior? ########## datafusion/spark/src/function/string/encode.rs: ########## Review Comment: Why is Spark 4 the default now, instead of an opt-in for one release? ########## datafusion/spark/src/function/string/encode.rs: ########## Review Comment: Were the bytes and error text verified against a real Spark 4.2 run? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
