ErikBPF commented on PR #7593: URL: https://github.com/apache/datafusion-comet/pull/7593#issuecomment-6769727613
@dwsmith1983 The upstream draft is now open, and I addressed your fork review in `60deafe94`: - A real planner regression covers local data with an S3-only DV bucket and checks SSE-C/CSE reason precedence. Removing DV URIs or reversing the gate order each makes it fail as expected. - Both test guards now detect the Hadoop key instead of a Spark version string. - Comments clarify the cold driver's scope and why the MinIO test disables filesystem caching. Docs explicitly cover conservative fallback on older Hadoop profiles. All 166 cases in the two affected suites pass, including four MinIO cases, as do Spark 4.2 and Spark 3.5 strict compilation. Production code is unchanged from the earlier 287-case full run. Could you review the follow-up coverage when you have time? I am keeping this as a draft; parser-based admission for valid contexts remains separate work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
