Phoenix500526 commented on PR #27285: URL: https://github.com/apache/datafusion/pull/27285#issuecomment-6770850336
> A couple of small things I missed earlier, none blocking: > > * The title says `fix:`, but nothing was broken before, so `perf:` or `refactor:` probably fits better. > * `num_rows` always equals `key.len()`, so the function could take one fewer argument. The issue suggested passing `num_rows`, so up to you. > > Also, the Rust CI jobs (clippy, cargo test) show as skipped here. I ran clippy and the `joins::hash_join` tests on [200f3e4](https://github.com/apache/datafusion/commit/200f3e4b7ef46afcecaf9e93c70d4d154e6558f3) locally and they pass. Thanks @dwsmith1983 I've removed the argument. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
