freakyzoidberg commented on PR #27303: URL: https://github.com/apache/datafusion/pull/27303#issuecomment-6777063875
> Probably this one is also worth a look > > ``` > first_value evaluate_bench nulls=0%, filter=false, first(2) 1.00 14.2±1.38µs ? ?/sec 1.67 23.7±212.66µs ? ?/sec > ``` Thanks, that one and the coalesce_peers (winner changes) should be fixed now. Before the per-batch scratch buffer was sized to the batch input row count (1 MB) and freed inside the timed closure (evaluate_bench improvement), now its capped to the number of groups (updates on the same group key are done in place in a scratch, then merge in the state at the end of batch - (coalesce_peers improvement)) Could you re-run run benchmark first_last? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
