ump45nose commented on code in PR #2698:
URL:
https://github.com/apache/datafusion-ballista/pull/2698#discussion_r4533410064
##########
ballista/scheduler/src/state/execution_graph.rs:
##########
@@ -192,6 +192,15 @@ pub trait ExecutionGraph: Debug {
executor_id: &str,
) -> Result<(HashSet<usize>, Vec<RunningTaskInfo>)>;
+ /// Return a bound-but-never-launched task to pending.
+ ///
+ /// Used when `launch_tasks` cannot dispatch a batch (e.g. a transient
+ /// executor-metadata miss) so the partitions are not left stranded as
+ /// `Running` with no status updates ever arriving. See #2691.
+ ///
+ /// Returns `true` when the task was still `Running` and was reset.
+ fn reset_unlaunched_task(&mut self, key: &TaskKey) -> bool;
Review Comment:
Done in cdf608d: `reset_unlaunched_task` now has a default body that returns
`false`, so out-of-tree `ExecutionGraph` implementations keep compiling.
`StaticExecutionGraph` and `AdaptiveExecutionGraph` both override it. Sorry for
not replying here earlier.
I also merged current `main` in 9b14201 to clear the conflict in
`state/aqe/mod.rs` (an import list). `cargo clippy -p ballista-scheduler
--all-targets -D warnings` is clean, and `cargo test -p ballista-scheduler
--lib` passes (627 passed, 2 ignored).
(AI-assisted reply.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
