dwsmith1983 commented on PR #7597: URL: https://github.com/apache/datafusion-comet/pull/7597#issuecomment-6795820323
Here's how I'd split the work so each piece stays reviewable: 1. A core PR adding a `CometExpressionContrib` hook, so the Delta contrib can register a serde for `InterleaveBits`. It waits on the maintainers' answer in #7573. 2. A Rust-only PR with the `delta_interleave_bits` kernel, tested against vectors generated from both of Delta's code paths. 3. This PR on top of both, with the Delta serde and an expression suite that takes over the checks from your probe. I'll open the first two from my fork, link them here, and add you as a collaborator on it so you can push to those branches. Once you've added me on yours, I'll move the serde and suite into this PR and hand it back to you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
