ted-jenks commented on code in PR #7528:
URL: https://github.com/apache/datafusion-comet/pull/7528#discussion_r4539331694
##########
native/spark-expr/src/conversion_funcs/numeric.rs:
##########
@@ -520,6 +520,16 @@ macro_rules! cast_float_to_int32_up {
}};
}
+/// 10^scale, or an error for a scale outside 0..=38. Negative scales need
+/// spark.sql.legacy.allowNegativeScaleOfDecimal and can still arrive from the
Parquet schema
+/// adapter.
Review Comment:
an INT32/INT64 column read as a negative scale decimal like DECIMAL(12,-2)
gets into cast_int_to_decimal128 via the schema adapter
happy to add the scan fallback and a test here, or do it as a follow up,
whichever you prefer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
