ErikBPF commented on PR #6112: URL: https://github.com/apache/datafusion-comet/pull/6112#issuecomment-6799262629
Merged current `main` (`e59d93730`) into this branch at head `9685a2e10` and revalidated it against the CI restructuring that landed after the review: #7311 (fork PR tier), #7516 (Spark SQL 4.1 / Iceberg 1.11 on every PR) and #7521 (Spark 3.4 removal). The only conflict was `dev/ci/check-ci-config.py`, where both sides appended new checks. The TPC assertions keep their original intent: exact-key restores, saves only on main, no `restore-keys`, both generators pinned, and scale factor/partition count shared between generator arguments, dataset paths and keys. Verification on the merged head: `python3 dev/ci/check-ci-config.py` passed, `dev/ci/test-fork-push-changed-files.py` (7 tests) and `dev/ci/test-fork-ci-status.cjs` passed. A mutation that puts `hashFiles(pr_build_linux.yml)` back into the TPC-H key still fails the check, so the assertion is not vacuous. GitHub now reports the PR mergeable with the approval retained. Ready for re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
