debugmiller commented on PR #59: URL: https://github.com/apache/datafusion-iceberg/pull/59#issuecomment-6807062391
Not a reviewer/committer but I also ran into this issue and decided to take a look. Some (hopefully) helpful observations to move this PR forward: - #91 has merged since this was opened. It stops the conversion from looking inside casts, so the cast half of this PR is already on `main` - the bind check in `scan.rs` drops the whole predicate when one filter fails to bind, which turns off pruning for every other filter on the scan. I have opened #104 for this, which keeps the conjuncts that do bind; and should also cover the `isnan` on an integer column issue here. GIven the above you can probably trim this down to a narrower PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
