parthchandra commented on code in PR #6996:
URL: https://github.com/apache/datafusion-comet/pull/6996#discussion_r4543503433
##########
spark/src/main/scala/org/apache/comet/serde/operator/IcebergWriteProtoTranslation.scala:
##########
@@ -100,6 +100,15 @@ object IcebergWriteProtoTranslation {
}
}
+ /**
+ * True when the write compresses with brotli. Unlike `resolveCompression`,
never throws. The
+ * name is matched the way iceberg-java matches it, upper-cased with
`Locale.ENGLISH`, so that
+ * `BROTLI` counts. It is also trimmed, so that a padded name, which the
codec parsing here
+ * accepts, is checked too.
Review Comment:
codecName already does .trim.toLowerCase(Locale.ROOT), then this method does
.trim.toUpperCase(Locale.ENGLISH). The second .trim is redundant, and the
scaladoc's "upper-cased with Locale.ENGLISH" is slightly misleading since the
string was already lowercased with Locale.ROOT first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
