Yupsecous opened a new pull request, #62: URL: https://github.com/apache/datafusion-spark/pull/62
## Which issue does this PR close? - Part of apache/datafusion#27239 (the Spark function files). - Ports apache/datafusion#27248, as asked in https://github.com/apache/datafusion/pull/27248#issuecomment-6803147017 now that `datafusion-spark` lives here. ## Rationale for this change An escaped regex on a `statement error` / `query error` line is hard to read and review. The plain-text form after `----` is exact and readable. ## What changes are included in this PR? Converts 19 error records in 4 files: | file | converted | |---|---| | crates/sqllogictest/test_files/math/abs.slt | 8 | | crates/sqllogictest/test_files/math/negative.slt | 5 | | crates/sqllogictest/test_files/string/elt.slt | 5 | | crates/sqllogictest/test_files/datetime/add_months.slt | 1 | Three more files stay unchanged, because their regex matches only the start of the error on purpose: `math/pmod.slt` (1 record), `map/map_from_entries.slt` and `map/map_from_arrays.slt` (4 records each). ## Are these changes tested? - `cargo test -p datafusion-spark-sqllogictest` passes (245 of 245 files) at `664a7be`, and the four files also passed on `main` before the change. - In the original PR I followed the steps in apache/datafusion#27239 for each record (`--complete` and a comparison), and kept a conversion only when the new message equals the old regex with the escapes removed. The same diff applies cleanly here. - To confirm the plain-text blocks are really checked, I changed one converted message in `math/abs.slt` (`SQLSTATE: 22003` to `22004`). The file then fails with an expected/actual mismatch. - Only `.slt` files changed, so `cargo fmt`, `cargo clippy` and `cargo test -p datafusion-spark` from AGENTS.md are unaffected, and I did not run them. ## Are there any user-facing changes? No. Test files only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
