comphead commented on code in PR #922: URL: https://github.com/apache/datafusion-comet/pull/922#discussion_r1762104579
########## docs/source/contributor-guide/plugin_overview.md: ########## @@ -17,30 +17,37 @@ specific language governing permissions and limitations under the License. --> -# Comet Plugin Overview +# Comet Plugin Architecture -The entry point to Comet is the `org.apache.spark.CometPlugin` class, which can be registered with Spark by adding the following setting to the Spark configuration when launching `spark-shell` or `spark-submit`: +## Comet SQL Plugin + +The entry point to Comet is the `org.apache.spark.CometPlugin` class, which can be registered with Spark by adding the +following setting to the Spark configuration when launching `spark-shell` or `spark-submit`: ``` --conf spark.plugins=org.apache.spark.CometPlugin ``` -On initialization, this class registers two physical plan optimization rules with Spark: `CometScanRule` and `CometExecRule`. These rules run whenever a query stage is being planned. +On initialization, this class registers two physical plan optimization rules with Spark: `CometScanRule` +and `CometExecRule`. These rules run whenever a query stage is being planned during Adaptive Query Execution. Review Comment: does that mean CometExecRule is not called if AQE is disabled? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
