alamb commented on code in PR #27375:
URL: https://github.com/apache/datafusion/pull/27375#discussion_r4554200867
##########
.github/workflows/rust.yml:
##########
@@ -393,7 +393,7 @@ jobs:
linux-cargo-check-datafusion-spark:
name: cargo check datafusion-spark features
needs: linux-build-lib
- if: ${{ !(github.event_name == 'push' && github.ref == 'refs/heads/main'
&& github.repository == 'apache/datafusion') && !(github.event_name ==
'pull_request' && github.event.pull_request.head.repo.fork && github.base_ref
== 'main') }}
+ if: ${{ !(github.event_name == 'pull_request' &&
github.event.pull_request.head.repo.fork && github.base_ref == 'main') }}
Review Comment:
why is the repository = 'apache/datafusion' check removed?
##########
.github/workflows/rust.yml:
##########
@@ -393,7 +393,7 @@ jobs:
linux-cargo-check-datafusion-spark:
name: cargo check datafusion-spark features
needs: linux-build-lib
- if: ${{ !(github.event_name == 'push' && github.ref == 'refs/heads/main'
&& github.repository == 'apache/datafusion') && !(github.event_name ==
'pull_request' && github.event.pull_request.head.repo.fork && github.base_ref
== 'main') }}
+ if: ${{ !(github.event_name == 'pull_request' &&
github.event.pull_request.head.repo.fork && github.base_ref == 'main') }}
Review Comment:
I guess it doesn't matter as this will be deleted
https://github.com/apache/datafusion/pull/27337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
