comphead commented on code in PR #26683: URL: https://github.com/apache/datafusion/pull/26683#discussion_r4566028178
########## docs/source/contributor-guide/testing_infrastructure.md: ########## @@ -10,16 +10,18 @@ This page covers checks for CI workflows, documentation, repository maintenance, ## CI Workflow Tests -The [Rust workflow validator tests] and [fork status bridge tests] run in CI and in `./dev/rust_lint.sh`. +The [Rust workflow validator tests], [fork status bridge tests] and [release version labeler tests] run in CI and in `./dev/rust_lint.sh`. Review Comment: Done in cb97e0b67. ########## ci/scripts/release_version_labeler.js: ########## Review Comment: Sound, although it only matters right after a version bump, while the new label does not exist yet. Fixed in cb97e0b67: a 422 from `createLabel` counts as success. A test covers it. With c24e43aac, a run that fails anyway is also recovered by the next push. ########## .github/workflows/release_version_labeler.yaml: ########## Review Comment: Fixed in cb97e0b67: a sparse checkout of `ci/scripts` with `persist-credentials: false`, like the other two workflows. ########## .github/workflows/release_version_labeler.yaml: ########## Review Comment: Yes, fixed in cb97e0b67. It was the only use of `actions/github-script` by tag on `main`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
