comphead commented on code in PR #12504:
URL: https://github.com/apache/datafusion/pull/12504#discussion_r1763546352
##########
datafusion/physical-plan/src/joins/nested_loop_join.rs:
##########
@@ -238,6 +238,19 @@ impl NestedLoopJoinExec {
PlanProperties::new(eq_properties, output_partitioning, mode)
}
+
+ fn maintains_input_order(join_type: JoinType) -> Vec<bool> {
Review Comment:
I feel it would be great to have some doc on what this method does and
return. Specifically what false/true means, what is the benefit of preserving
the order
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
