raghavyadav01 commented on PR #27019:
URL: https://github.com/apache/datafusion/pull/27019#issuecomment-6888843833

   Heads-up on this one given alamb's note in #5492 about not breaking queries 
that worked in a release: this PR makes the EXISTS form of `(SELECT * FROM t2 
AS s WHERE s.a = t.a) x CROSS JOIN (SELECT * FROM t2 AS s WHERE s.a = t.a) y` 
error, and that returns correct rows in 55.2.0. Narrowing the guard doesn't 
work cleanly because both maps are keyed by plan value, so the second copy 
overwrites the first copy's entry before any check can compare them. The proper 
fix is to key them by node position instead. @jayzhan211 would you rather I do 
that here, or keep this PR and accept the one regression?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to